Merged
Conversation
astrochemx
force-pushed
the
fix/eslint-10-support
branch
from
3d5a167 to
e9af294
Compare
Contributor
|
@amilajack ESLint v10 has now been released, may I request your review on this? 🙏 |
dargmuesli
reviewed
Feb 7, 2026
Contributor
dargmuesli
left a comment
dargmuesli
left a comment
There was a problem hiding this comment.
I think these changes can be made now
This was referenced Feb 7, 2026
Co-authored-by: Jonas Thelemann <e-mail+github@jonas-thelemann.de>
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
|
@amilajack codex seems to be happy, do you think we can release this? |
amilajack
approved these changes
Feb 18, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 18, 2026
# [6.2.0](v6.1.0...v6.2.0) (2026-02-18) ### Features * eslint 10 support ([#677](#677)) ([6aaec34](6aaec34))
|
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
Thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the plugin to support ESLint v10 and ensures compatibility across ESLint v8, v9, and v10.
Fixes #675.
Key Changes
package.json:peerDependenciesto alloweslint@^10.0.0.typescript-eslintversion to the latest to support ESLint v10.eslint-plugin-eslint-pluginto the latest minor in the version range to fix TS error ineslint.config.mjs.src/rules/compat.ts:contextproperty access to support both the deprecated in ESLint v9 (and completely removed in ESLint v10) methods (context.getSourceCode()andcontext.getFilename()), and the new ESLint v9+ properties (context.sourceCodeandcontext.filename).as unknown as Rule.RuleModule) for thecreatefunction return type to resolve TypeScript conflicts between strict internal node types and ESLint's genericRuleModuleinterface.test/e2e.spec.ts:RuleTestererror assertions, as this property was marked as deprecated in ESLint v9 and completely removed in ESLint v10..github/workflows/test.yml:10(ESLint v10) to the ESLint test matrix.--legacy-peer-depsto thenpm i -D eslint@${{ matrix.eslint-version }}to allow ESLint v10 to be installed as an unsupported peer dependency for other packages.Run testsstep logic to runnpm testfor ESLint v8 only andnpm run spec ...for ESLint v9+.Run e2e testsstep logic to run only on ESLint v8.Breaking Changes
None. This PR maintains backward compatibility with supported ESLint versions.
Suggestions
We should probably also address the issue that came up during the linting:
Browserslist: browsers data (caniuse-lite) is 6 months old.